SceneMaker / VisualSceneMaker

Visual SceneMaker is an authoring tool for creating interactive presentations aimed to non-programming experts. It supports the modeling of verbal and non-verbal behavior of Virtual Characters and robots. Therefore, it provides users with a graphical interface and a simple scripting language that allows them to create rich and compelling content.
http://scenemaker.dfki.de
Other
18 stars 11 forks source link

PlayAction parser doesn't match floats un scientific format #230

Closed fnunnari closed 3 years ago

fnunnari commented 3 years ago

When executing a scene like:

PlayAction("[botty set_tcp_target x=-0.43 y=-0.56 z=0.55 or_w=4.456203E-4]")`

the parser would assign or_w to 4.456203. It ignores the "scientific notation"

gMehlmann commented 3 years ago

Adapt the flex file's regular expressions for floats and/or cup grammar to cover such notations.

Fabrizio Nunnari @.***> schrieb am Do., 24. Juni 2021, 17:49:

When executing a scene like:

PlayAction("[botty set_tcp_target x=-0.43 y=-0.56 z=0.55 or_w=4.456203E-4]")`

the parser would assign or_w to 4.456203. It ignores the "scientific notation"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SceneMaker/VisualSceneMaker/issues/230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2QOJF7OJVDPJAGOZFVGSDTUNHZTANCNFSM47IFGUUQ .

fnunnari commented 3 years ago

Adapt the flex file's regular expressions for floats and/or cup grammar to cover such notations.

Looks like the parsing was not done by Flex, but rather by a custom regular expression hand-written by Patrick.

gMehlmann commented 3 years ago

Right, I remember, whoever it was 😊 Using Antlr would allow to parse such expressions with the same grammar as used for scenes...

Fabrizio Nunnari @.***> schrieb am So., 27. Juni 2021, 16:11:

Adapt the flex file's regular expressions for floats and/or cup grammar to cover such notations.

Looks like the parsing was not done by Flex, but rather by a custom regular expression hand-written by Patrik.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SceneMaker/VisualSceneMaker/issues/230#issuecomment-869170273, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2QOJH6GVV6JWDIXLF7BITTU4WS5ANCNFSM47IFGUUQ .