Sceptre / sceptre

Build better AWS infrastructure
https://docs.sceptre-project.org
Other
1.49k stars 313 forks source link

[Resolve #1436] Handle exception in differ #1437

Closed alex-harvey-z3q closed 9 months ago

alex-harvey-z3q commented 9 months ago

See also Issue #1336. Before this change, in the event of Parameters being entered of types other than str (e.g. bool, presumably float, int etc), the differ would bomb out with a confusing AttributeError error when trying to rstrip newline characters.

This changes to instead raise a SceptreException at that point, with an informative error message to help the caller understand what they did wrong.

PR Checklist

Approver/Reviewer Checklist

Other Information

Guide to writing a good commit