SchemaPlus / schema_plus_pg_indexes

Adds support in ActiveRecord for PostgreSQL index expressions and operator classes, as well as a shorthand for case-insensitive indexes
MIT License
30 stars 13 forks source link

Please upgrade gem for Rails 5.1.0 #15

Closed jasnow closed 7 years ago

jasnow commented 7 years ago

Getting

    schema_plus_pg_indexes was resolved to 0.1.0, which depends on
      activerecord (~> 4.2)

for Rails 5.1 and Ruby 2.4.1 on Mac 10.12.4.

elsurudo commented 7 years ago

@jasnow For now, feel free to use my fork that relaxes the requirements:

In your gemfile:

gem 'schema_plus_pg_indexes'
gem 'schema_plus_indexes', git: 'https://github.com/elsurudo/schema_plus_indexes.git', branch: 'rails-5.1'

I haven't tested it much yet – will report any issues I come across.

jasnow commented 7 years ago

Above workaround allow me to upgrade from Rails 5.1.0.rc2 to 5.1.0.

elsurudo commented 7 years ago

Just note that there's probably a reason that the requirements are strict – the implementation of these gems is tied pretty closely to the activerecord API, so if that changes, things may break in subtle ways. So testing is important.

iagopiimenta commented 7 years ago

Any progress with this?

ronen commented 7 years ago

Any progress with this?

Not much. schema_plus_core needs some (hopefully minor) work to conform to 5.1 then the other gems can build off that, hopefully without too much work. Really hoping that somebody will motivate to dive in as I myself don't have time right now. See SchemaPlus/schema_plus_core#19

ronen commented 7 years ago

Thanks to @iagopiimenta, schema_plus_core has been updated. Then it was a quick matter for me to update this gem. Version 0.3.0 is released now.

jasnow commented 7 years ago

Verified - Thanks

ronen commented 7 years ago

@jasnow thanks for confirming

jasnow commented 7 years ago

Always glad to help