search

SciLifeLab / bcbb

Useful bioinformatics code, primarily in Python and R
http://bcbio.wordpress.com
10 stars 11 forks source link

Add redis handler to bcbio! #280

Closed guillermo-carrasco closed 11 years ago

guillermo-carrasco commented 11 years ago

This PR add Redis to the logging options in bcbio. Also re-structures a little bit the logging process appending all the handlers to a NestedSetup handler, which basically will group all the handlers (so we can log in multiple places).

Please @b97pla , take a look at this. I've already tested my branch in b5, if you check the config file for illumina_finish_msg.py you'll see the Redis parameters.

Tack!

b97pla commented 11 years ago

@guillermo-carrasco Nice work!

guillermo-carrasco commented 11 years ago

@b97pla I'm showing a warning now. As I told you I prefer to do that because I feel like is kind of drastic to stop the pipeline if it fails to load Redis handler (I think is quite possible that there can be network glitches between UPPMAX and tools). Do you think is ok?

@mariogiov , @mayabrandi , please, when you have a moment could you review this PR? Tack!

b97pla commented 11 years ago

Yes, absolutely, I agree!

On Wed, Oct 16, 2013 at 9:43 AM, Guillermo Carrasco < notifications@github.com> wrote:

@b97pla https://github.com/b97pla I'm showing a warning now. As I told you I prefer to do that because I feel like is kind of drastic to stop the pipeline if it fails to load Redis handler (I think is quite possible that there can be network glitches between UPPMAX and tools). Do you think is ok?

@mariogiov https://github.com/mariogiov , @mayabrandihttps://github.com/mayabrandi, please, when you have a moment could you review this PR? Tack!

— Reply to this email directly or view it on GitHubhttps://github.com/SciLifeLab/bcbb/pull/280#issuecomment-26398452 .

Pontus Larsson, PhD Science For Life Laboratory www.scilifelab.se

Email: Pontus.Larsson@scilifelab.se Phone: +46 8 5248 1440

Mobile: +46 76 946 9788