Open milesfrain opened 5 years ago
Also considered attempting to upgrade the app from angular2 to angular8, but I don't have much confidence in this succeeding. https://update.angular.io/#2.0:8.0
Yes, this library is setup for Angular2 and Julia 0.5. It needs an update
The front-end used a very early version of Angular 2+, but fortunately its very simple -- I can rewrite it in current Angular. @ChrisRackauckas I remember we were waiting on something to update the backend to Julia 1.x -- is that possible now or are we still blocked?
It was the compilation setup. I think we can do that now just by using FunctionWrappers.
I'm having trouble building this project, even when attempting to match the older Angular version. Could someone run through the build steps on their machine and confirm they still work today?
Here are my steps for reference:
This results in a
Cannot find module '@angular/compiler-cli/ngcc'
error, and a bunch ofUNMET PEER DEPENDENCY
warnings undernpm list -g -depth 0
I put together a more detailed log of troubleshooting steps below:
Starting conditions:
Global packages:
Nothing other than npm installed.
Local packages:
Nothing installed. Unmet dependencies expected.
After installing angular-cli:
npm install -g angular-cli@1.0.0-beta.19-3
Peer dependency warnings in build log:
Global packages.
angular-cli
added. Lots of missing peer dependency warnings. I assume I need to manually install all of these. Will attempt that after thenpm install
step.Local packages:
Listing is unchanged, as expected. (log omitted for brevity).
After installing local dependencies:
npm install
This adds some of the missing local package dependencies, but there are lots of unmet peer dependencies.Local packages:
Global packages:
Listing is unchanged, as expected. (log omitted for brevity).
Attempting to install an unmet peer dependency
Let's look at one of the first dependency errors in our local listing:
UNMET PEER DEPENDENCY @angular/common@2.1.2
andnpm ERR! peer dep missing: @angular/common@^2.2.0, required by clarity-angular@0.7.5-dev
I'm interpreting this as
@angular/common@2.1.2
is currently installed, but we need to bump this to2.2.0
to satisfyclarity-angular
requirements.I see the following lines in
package.json
"@angular/common": "^2.1.2",
"clarity-angular": "^0.7.5-dev",
Installing required version with:
npm install @angular/common@2.2.0
This updated package.json too.Now the local listing shows this pair of errors:
UNMET PEER DEPENDENCY @angular/common@2.2.0
npm ERR! peer dep missing: @angular/common@2.1.2, required by @angular/forms@2.1.2
So there's a mismatch where:
@angular/common@2.1.2
is required by@angular/forms@2.1.2
but@angular/common@^2.2.0
is required byclarity-angular@0.7.5-dev
I'm assuming it's safer to bump the minor version of
@angular/forms
and friends to2.2.0
.Another conflict is
@webcomponents/custom-elements@1.0.0-alpha.3, required by clarity-icons@0.7.5-dev
where@webcomponents/custom-elements@1.2.4
is installed. Probably not good to revertcustom-elements
, but the next version ofclarity-icons
is a major version bump, so seems like things may break either way. It also seems impossible to update clarity-icons to a point where it's compatible with custom-elements@1.2.4, since the latest version (as of today) only goes up to 1.1.0 https://github.com/vmware/clarity/blob/9749d669943adf7e53d71b84ec0eaee8a3bc7137/package.json#L92 I'm wondering if I can just ignore this unmet peer dependency.Here's a diff of what seems to have cut down on most peer dependency issues
But a bunch still remain:
Attempting
ng serve
at this point still results in aCannot find module '@angular/compiler-cli/ngcc'
error.