SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)
https://diffeq.sciml.ai/latest/
Other
536 stars 205 forks source link

threading vs thread in solver algorithms #2435

Open ArnoStrouwen opened 1 month ago

ArnoStrouwen commented 1 month ago

Some solvers use thread = OrdinaryDiffEq.True(), other use threading = true, even though to me it looks like these keywords represent the same functionality. It would be good to make this uniform for the next breaking release #2310 .

ChrisRackauckas commented 1 month ago

They should all use the Static.jl form so that it can be handled at compile time. It shouldn't be true/false either, since PolyesterThreads is an answer. IIRC there is a 3 valued logic version defined.