Closed Dolgalad closed 2 years ago
Merging #45 (6977caf) into main (6282950) will decrease coverage by
1.44%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 87.23% 85.79% -1.45%
==========================================
Files 31 31
Lines 1489 1499 +10
Branches 252 253 +1
==========================================
- Hits 1299 1286 -13
- Misses 127 150 +23
Partials 63 63
Flag | Coverage Δ | |
---|---|---|
unittests | 85.79% <100.00%> (-1.45%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
speasy/products/variable.py | 93.81% <100.00%> (+0.71%) |
:arrow_up: |
speasy/webservices/amda/_impl.py | 72.04% <0.00%> (-13.98%) |
:arrow_down: |
speasy/webservices/amda/rest_client.py | 75.55% <0.00%> (-6.67%) |
:arrow_down: |
speasy/core/__init__.py | 95.00% <0.00%> (-2.50%) |
:arrow_down: |
speasy/webservices/amda/ws.py | 86.39% <0.00%> (-2.05%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6282950...6977caf. Read the comment docs.
This pull request introduces 1 alert when merging e6b1d4e0888c07383b3874fbabfed272f12ff934 into 6282950d59d0079fe59698d95f971809e02160ec - view on LGTM.com
new alerts:
This pull request introduces 1 alert when merging e6b1d4e into 6282950 - view on LGTM.com
new alerts:
- 1 for Except block handles 'BaseException'
I think this one is quite legit, you should catch a ValueError.
It looks good to me, except for the LGTM issue and it has 0 unit test. I think this must be tested with at leas one product of
Tests for to_astropy_table
implemented in tests.test_spwc_variable
Perfect, thank you.
Solves Issue #44