codecov[bot]
commented
1 year ago Codecov Report
Base: 78.65% // Head: 84.67% // Increases project coverage by +6.01% :tada:
Coverage data is based on head (
cec72c8) compared to base (fb9fbc2). Patch coverage: 66.66% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #52 +/- ## ========================================== + Coverage 78.65% 84.67% +6.01% ========================================== Files 44 44 Lines 2516 2518 +2 Branches 373 374 +1 ========================================== + Hits 1979 2132 +153 + Misses 423 261 -162 - Partials 114 125 +11 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `84.67% <66.66%> (+6.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/SciQLop/speasy/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop) | Coverage Δ | | |---|---|---| | [speasy/core/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvX19pbml0X18ucHk=) | `87.30% <0.00%> (-3.03%)` | :arrow_down: | | [...ces/cda/\_inventory\_builder/\_xml\_catalogs\_parser.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2NkYS9faW52ZW50b3J5X2J1aWxkZXIvX3htbF9jYXRhbG9nc19wYXJzZXIucHk=) | `83.01% <100.00%> (+83.01%)` | :arrow_up: | | [speasy/webservices/amda/rest\_client.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvcmVzdF9jbGllbnQucHk=) | `78.21% <0.00%> (-2.98%)` | :arrow_down: | | [speasy/webservices/amda/inventory.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvaW52ZW50b3J5LnB5) | `78.30% <0.00%> (-1.89%)` | :arrow_down: | | [speasy/webservices/amda/ws.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvd3MucHk=) | `85.61% <0.00%> (+0.68%)` | :arrow_up: | | [speasy/webservices/amda/\_impl.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvX2ltcGwucHk=) | `75.70% <0.00%> (+0.93%)` | :arrow_up: | | [speasy/core/dataprovider.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvZGF0YXByb3ZpZGVyLnB5) | `88.57% <0.00%> (+1.42%)` | :arrow_up: | | [speasy/webservices/cda/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2NkYS9fX2luaXRfXy5weQ==) | `82.14% <0.00%> (+3.57%)` | :arrow_up: | | [speasy/core/inventory/indexes.py](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvaW52ZW50b3J5L2luZGV4ZXMucHk=) | `86.45% <0.00%> (+8.33%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/SciQLop/speasy/pull/52/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
It seems that some instruments nodes names are empty so just skip them and just directly add datasets nodes into parent node.
It might not be enough to cover all cases, a more systematic analysis might be required to spot all "broken nodes".