SciQLop / speasy

Space Physics made EASY! A simple Python package to deal with main Space Physics WebServices (CDA,SSC,AMDA,..)
Other
24 stars 7 forks source link

Fixes regression on CSA inventory construction #54

Closed jeandet closed 1 year ago

jeandet commented 1 year ago

A mix-up between dataset normalized and regular id made speasy miss few products.

codecov[bot] commented 1 year ago

Codecov Report

Base: 79.00% // Head: 86.02% // Increases project coverage by +7.02% :tada:

Coverage data is based on head (678e6de) compared to base (ebc6560). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #54 +/- ## ========================================== + Coverage 79.00% 86.02% +7.02% ========================================== Files 44 44 Lines 2553 2555 +2 Branches 386 386 ========================================== + Hits 2017 2198 +181 + Misses 421 238 -183 - Partials 115 119 +4 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `85.28% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/SciQLop/speasy/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop) | Coverage Δ | | |---|---|---| | [speasy/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L19faW5pdF9fLnB5) | `93.75% <100.00%> (ø)` | | | [speasy/core/dataprovider.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvZGF0YXByb3ZpZGVyLnB5) | `89.47% <100.00%> (+1.31%)` | :arrow_up: | | [speasy/core/index/speasy\_index.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvaW5kZXgvc3BlYXN5X2luZGV4LnB5) | `100.00% <100.00%> (+9.09%)` | :arrow_up: | | [speasy/webservices/csa/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2NzYS9fX2luaXRfXy5weQ==) | `84.80% <100.00%> (+33.59%)` | :arrow_up: | | [speasy/config/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvbmZpZy9fX2luaXRfXy5weQ==) | `95.38% <0.00%> (-1.54%)` | :arrow_down: | | [speasy/webservices/amda/ws.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvd3MucHk=) | `85.61% <0.00%> (+0.68%)` | :arrow_up: | | [speasy/core/proxy/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvcHJveHkvX19pbml0X18ucHk=) | `84.61% <0.00%> (+2.19%)` | :arrow_up: | | [speasy/webservices/amda/rest\_client.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvcmVzdF9jbGllbnQucHk=) | `84.15% <0.00%> (+2.97%)` | :arrow_up: | | [speasy/webservices/cda/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2NkYS9fX2luaXRfXy5weQ==) | `82.14% <0.00%> (+3.57%)` | :arrow_up: | | ... and [7 more](https://codecov.io/gh/SciQLop/speasy/pull/54/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.