SciQLop / speasy

Space Physics made EASY! A simple Python package to deal with main Space Physics WebServices (CDA,SSC,AMDA,..)
Other
24 stars 7 forks source link

Uses cache setting also when loading inventory from proxy #57

Closed jeandet closed 1 year ago

jeandet commented 1 year ago

Closes #56

This reduces import time from few seconds to less than one second.

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.51% // Head: 85.64% // Increases project coverage by +1.12% :tada:

Coverage data is based on head (964ff7e) compared to base (2ed5c22). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #57 +/- ## ========================================== + Coverage 84.51% 85.64% +1.12% ========================================== Files 44 44 Lines 2558 2564 +6 Branches 388 389 +1 ========================================== + Hits 2162 2196 +34 + Misses 269 244 -25 + Partials 127 124 -3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `84.90% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/SciQLop/speasy/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop) | Coverage Δ | | |---|---|---| | [speasy/core/proxy/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L2NvcmUvcHJveHkvX19pbml0X18ucHk=) | `81.44% <100.00%> (-0.98%)` | :arrow_down: | | [speasy/webservices/amda/ws.py](https://codecov.io/gh/SciQLop/speasy/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvd3MucHk=) | `85.61% <0.00%> (+0.68%)` | :arrow_up: | | [speasy/webservices/amda/rest\_client.py](https://codecov.io/gh/SciQLop/speasy/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvcmVzdF9jbGllbnQucHk=) | `84.15% <0.00%> (+2.97%)` | :arrow_up: | | [speasy/webservices/ssc/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL3NzYy9fX2luaXRfXy5weQ==) | `91.13% <0.00%> (+10.12%)` | :arrow_up: | | [speasy/webservices/amda/\_impl.py](https://codecov.io/gh/SciQLop/speasy/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2FtZGEvX2ltcGwucHk=) | `85.04% <0.00%> (+10.28%)` | :arrow_up: | | [...asy/webservices/cda/\_inventory\_builder/\_\_init\_\_.py](https://codecov.io/gh/SciQLop/speasy/pull/57/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop#diff-c3BlYXN5L3dlYnNlcnZpY2VzL2NkYS9faW52ZW50b3J5X2J1aWxkZXIvX19pbml0X18ucHk=) | `94.44% <0.00%> (+12.96%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciQLop)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

RichardHitier commented 1 year ago

Hi, sorry for my under reactivity. And thank your very much for the enhancement: it really is faster now.