Move chart_class, modules and css to third parameter in HighCharts

SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.

https://sciruby.github.io/daru-view/

MIT License

95 stars 20 forks source link

Move chart_class, modules and css to third parameter in HighCharts #120

Closed Prakriti-nith closed 5 years ago

Prakriti-nith commented 5 years ago

Shifted chart_class, modules and css to the third parameter and updated all the IRuby examples accordingly. Need to update the examples in demo_daru-view and wiki.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 674

20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 98.132%

Totals
Change from base Build 670:	0.002%
Covered Lines:	3204
Relevant Lines:	3265

Pull Request Test Coverage Report for Build 675

20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 98.132%

Totals
Change from base Build 670:	0.002%
Covered Lines:	3204
Relevant Lines:	3265

💛 - Coveralls

Prakriti-nith commented 5 years ago

@Shekharrajak can you please review this PR?

Prakriti-nith commented 5 years ago

Yes, I have updated all the IRuby examples and also checked all of them again in this PR. I have updated the examples of Highcharts in demo_daru-view in this PR and have also added the updated CSS example in daru_examples_io_view_rails in this PR. Updated the wiki images and examples link in Highcharts' features page and Progress Report.