search

SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.
https://sciruby.github.io/daru-view/
MIT License
95 stars 20 forks source link

[DataTables]: Need to change require path #122

Open Shekharrajak opened 5 years ago

Shekharrajak commented 5 years ago

If issue: https://github.com/Shekharrajak/daru-data_tables/issues/24 is done , then related changes has to be done in daru-view/datatables

Shekharrajak commented 5 years ago

Note : Has to finish before new release : https://github.com/SciRuby/daru-view/pull/123

v0dro commented 5 years ago

I guess this is done?

Shekharrajak commented 5 years ago

@v0dro , actually code point of view it is done in https://github.com/Shekharrajak/daru-data_tables/pull/22 and https://github.com/SciRuby/daru-view/pull/114, but we still have old folder structure https://github.com/Shekharrajak/daru-data_tables/pull/22#issuecomment-414583306 ; if we rearrange the folder structure in daru-data_tables then we need to change the path in daru-view as well. refer : https://github.com/SciRuby/daru-view/pull/114#pullrequestreview-148815322