search

SciSharp / LLamaSharp

A C#/.NET library to run LLM (🦙LLaMA/LLaVA) on your local device efficiently.
https://scisharp.github.io/LLamaSharp
MIT License
2.72k stars 352 forks source link

CI: make unzip target depend on download target #848

Closed m0nsky closed 4 months ago

m0nsky commented 4 months ago

Attempt to fix CI randomly failing due to "because the file does not exist or is inaccessible" when trying to unzip the deps from LLamaBinaries.

Microsoft mentions the following for the target build order:

In general, you shouldn't depend on the declaration order to specify what tasks run before other tasks.

This PR splits up the download & unzip targets and makes the unzip target depend on the download target, so that they can never be executed in the wrong order, and adds download retries so that the build does not fail if there is a temporary issue when downloading the file.

martindevans commented 4 months ago

Looks like this is still failing due to the zip file not existing.

martindevans commented 4 months ago

Thankyou for all the hard work debugging this!