Align ubuntu versions across workflow

SciSharp / LLamaSharp

A C#/.NET library to run LLM (🦙LLaMA/LLaVA) on your local device efficiently.

https://scisharp.github.io/LLamaSharp

MIT License

2.72k stars 351 forks source link

Align ubuntu versions across workflow #850

Closed m0nsky closed 4 months ago

m0nsky commented 4 months ago

This PR aligns all Ubuntu versions in the compilation workflow by updating the 20.04 versions to 22.04 as previously both versions were mixed throughout the file.

Since the binaries are now distributed through SciSharp/LLamaSharpBinaries, I think this should go there instead of the main repo (?). I ran a Update Binaries action for this PR over here which succeeded.

Submitting as a draft for now because:

The change is not necessary
I'm wondering if this raises the minimum OS for the end user to 22.04, or if this is not related at all

martindevans commented 4 months ago

In https://github.com/SciSharp/LLamaSharp/pull/297 we specifically moved back to 20.04, which fixed an issue with older versions of GLIBC in docker. I don't know enough about docker/Linux to say if this is still important though.

m0nsky commented 4 months ago

Thanks, that's what I was wondering. The initial Vulkan PR targeted 22.04, so I kept that in the new Vulkan PR. That might cause the original docker compatibility issue to pop back up in the Vulkan backend, but for now I think I'll close this PR until it is confirmed. What do you think?

martindevans commented 4 months ago

I think it's best to close it for now yeah. I'm happy to wait until someone reports a similar issue with Vulkan before changing the target there.