search

SciSpike / yaktor-issues

Issues-only repository for issue management of all Yaktor repositories
0 stars 1 forks source link

[CLOSED] Modify custom function signature generation for state transitions to change argument name "data" to name of event #48

Closed matthewadams closed 8 years ago

matthewadams commented 8 years ago

Issue by gacord23 Wednesday Sep 14, 2016 at 16:14 GMT Originally opened as https://github.com/SciSpike/yaktor-dsl-xtext/issues/7

This is purely a usability issue.

Given state transition receives custom checkIn becomes waitingForAssistance sends checkedIn the generator creates custom function signature function(causedByEventName,meta,data,done)

Since the term data wasn't meaningful to me, I inadvertently overwrote it in my custom routine. Had the generator used the event name checkIn instead of data, like function(causedByEventName,meta,checkIn,done) it may have made things more obvious.

matthewadams commented 8 years ago

Comment by matthewadams Friday Sep 16, 2016 at 14:58 GMT

FYI, started work in branch https://github.com/SciSpike/yaktor-dsl-xtext/tree/7.

matthewadams commented 8 years ago

Comment by matthewadams Tuesday Nov 22, 2016 at 17:55 GMT

This issue was moved to SciSpike/yaktor-issues#5