search

Scifabric / pybossa

PYBOSSA is the ultimate crowdsourcing framework (aka microtasking) to analyze or enrich data that can't be processed by machines alone.
http://pybossa.com
GNU Affero General Public License v3.0
745 stars 269 forks source link

fix: rq_dashboard redis problem #1988

Closed jokruger closed 4 years ago

jokruger commented 4 years ago

In core.py:329 it overrides app config with default values from rq_dashboard. As result it is not possible to use external redis because default value for REDIS_HOST is localhost, i.e. rq_dashboard is always works with localhost.

It will be much better to remove this line and just use settings from app config - this way you will be able to configure app and rq_dashboard.

teleyinex commented 4 years ago

I think this PR has failed because you fixed first the REDIS_DB and therefore, this one is picking the correct REDIS config for rq-dashboard. I've tested it here #1990. Thus, if you want, add the docs to the #1987 so we can merge it, and then I'll merge this one as it should be rebased to get these changes. What do you think?

jokruger commented 4 years ago

Looks like something go wrong with my git -- it start merging all separate feature branches into single one during PR :( I will try to figure out what is wrong..