Scille / parsec-cloud

Open source Dropbox-like file sharing with full client encryption !
https://parsec.cloud
Other
268 stars 40 forks source link

[Vue] TypeError: Cannot read properties of undefined (reading 'setLoginError') #8204

Open mmmarcos opened 1 month ago

mmmarcos commented 1 month ago

The following error is reported multiple times when running Playwright E2E2 tests locally.

>  [Vue warn]: Error in component event handler: "TypeError: Cannot read properties of undefined (reading 'setLoginError')"
found in
---> <OrganizationListPage> at /home/marcos/code/scille/parsec-cloud/client/src/views/home/OrganizationListPage.vue... (4 recursive calls)
       <HomePage> at /home/marcos/code/scille/parsec-cloud/client/src/views/home/HomePage.vue
         <IonRouterOutlet>... (1 recursive calls)
           <Root>

Seen on:

[chromium] › create_organization_custom.spec.ts:32:1 › Go through custom org creation process

[chromium] › create_organization_saas.spec.ts:166:1 › Go through saas org creation process from bootstrap link

[chromium] › create_organization_trial.spec.ts:133:1 › Go through trial org creation process from bootstrap link

[chromium] › create_organization_trial.spec.ts:33:1 › Go through trial org creation process
Max-7 commented 2 weeks ago

This occurs because we're using playwright in web mode, with everything mocked but with the testbed. We create a fake organization with a fake device, and at the end of the process, we try to log in. Except the device that was returned by the org creation process is not valid (it does not exist anywhere, all data are completely fake), so trying to log on to it is meaningless.

Yes we could try and handle this error but since it only occurs because of mocked data + real login, it's a bit of a waste. It'll take care of itself once we have the bindings for the web platform.