search

Scratch-Client-4 / client

🖥 The SC4 desktop client. Devlopement currently halted while we work on our mobile client : https://github.com/Scratch-Client-4/mobile
GNU General Public License v3.0
11 stars 1 forks source link

Improve SCSS #5

Closed locness3 closed 4 years ago

locness3 commented 4 years ago

I'm new to SASS tho, not sure if I'm using best practices. Also, SASS recommends not to use @import anymore.

Thoughts? cc @micahlt @Hexsphere

locness3 commented 4 years ago

cc @Scratch-Client-4/frontend

VFDan commented 4 years ago

Personally, I prefer Less, but I could help you a bit with SCSS

locness3 commented 4 years ago

Personally, I prefer Less, but I could help you a bit with SCSS

I too prefer LESS, but the project's already in SCSS. I didn't want to change. I'd love using LESS, but I guess we need an approval from others at @Scratch-Client-4/frontend

VFDan commented 4 years ago

Why are you using CSS vars along with SCSS?

retronbv commented 4 years ago

I’m confused what is scss is it the same as css bc it looks the same

locness3 commented 4 years ago

Why are you using CSS vars along with SCSS?

CSS vars are mofified by JS to switch between light/dark mode. I didn't make this tho, it's @micahlt.

micahlt commented 4 years ago

@locness3 @VFDan To be honest, this is my first time using Sass, and I'm just using it because @Hexsphere recommended it. I'll talk to him about possibly switching to Less. The CSS vars are there to allow easy switching between light and dark theme without page reloads. I wasn't aware @import was depreciated- I tend to prefer it. And great job splitting the code up- I wasn't sure how much fragmentation was best. And finally, don't get too invested in styling- if anything work on the Javascript end of things because the design team (me, @Hexsphere, and @Ekmand) is still working on design consistency on Figma. I won't merge this PR until @Hexsphere checks it over.

locness3 commented 4 years ago

I’m confused what is scss is it the same as css bc it looks the same

SASS is a CSS preprocessor, a program that takes a custom syntax, with additional features than plain CSS like variables or nesting and converts it to plain CSS. SCSS is a syntax for SASS.

locness3 commented 4 years ago

I wasn't aware @import was depreciated- I tend to prefer it.

CSS @import isn't tho, just SASS's.

locness3 commented 4 years ago

CSS @import isn't tho, just SASS's. By that I mean the one you use to import webfonts and such.

VFDan commented 4 years ago

Should I change the @imports? (@locness3)

micahlt commented 4 years ago

@VFDan feel free to do so, but in a different PR as this has been merged.

VFDan commented 4 years ago

👍

locness3 commented 4 years ago

Well, thanks for merging!