search

Scratch-Client-4 / itchy-cordova

📱 Cordova-based mobile client for Scratch
17 stars 4 forks source link

Make the JavaScript code cleaner and reusable #30

Open moeenio opened 4 years ago

moeenio commented 4 years ago

I'm okay with going no-framework (#11), but then we should make the JS code cleaner and reusable, using classes and all that stuff. These would be split into multiple files.

moeenio commented 4 years ago

void

micahlt commented 4 years ago

@locness3 What exactly do you mean by classes? I'm all for cleaning up (and documenting) the JavaScript.

moeenio commented 4 years ago

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes I mean classes

micahlt commented 4 years ago

I've modularized the JS as much as I feel is necessary in 272d5ba90b53c9a43116699952d3af59fabda0fa.

moeenio commented 4 years ago

Pretty nice already.

micahlt commented 4 years ago

Thanks :)

moeenio commented 4 years ago

Now I think we should :

  1. Use the class IdkWhat and import IdkWhat from "file.js" syntaxes, that Parcel allows us to use.
  2. Adopt a design pattern such as Model-View-Controller.
moeenio commented 4 years ago

Also, I suggest once again that we use lit-html.

moeenio commented 4 years ago

...hi?

micahlt commented 4 years ago

If you're asking about activity here, I'm currently working on improving the project viewer page. The code is already clean enough to ship. I'm really trying to make the release date of Christmas. At some point, yeah, lit-html would be useful. Currently, I have higher priorities. If you'd like to work on it after I merge the next PR, that's fine with me.

On Fri, Nov 6, 2020, 10:04 AM Locness notifications@github.com wrote:

...hi?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Scratch-Client-4/itchy-cordova/issues/30#issuecomment-723160063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG33HKOIKLAH3HOYO6CLY53SOQNCNANCNFSM4SK3UB2Q .

moeenio commented 4 years ago

Okay, I'll try to give some time.