ScratchAddons / ScratchAddons

All-in-one browser extension for Scratch.
https://scratchaddons.com
GNU General Public License v3.0
723 stars 371 forks source link

Show the number of unread messages on the "Messaging" tab in the popup #5127

Open mxmou opened 2 years ago

mxmou commented 2 years ago

Why this would be helpful/solve a problem

Opening the popup now activates the last opened tab. If there are unread messages and the Messaging tab is not selected, the user might not know where they can view the messages.

What this change does

Show the number of unread messages on the Messaging tab. image

Possible alternatives

Always focus the Messaging tab if there are unread messages, but that could be annoying.

Demonstration(s) and additional context

No response

penguinmoose commented 2 years ago

I think it might look a bit nicer if the message count would be shown in parenthesis instead of being a badge. Something like "Messaging (123)".

BroJac5246 commented 2 years ago

I think it might look a bit nicer if the message count would be shown in parenthesis instead of being a badge. Something like "Messaging (123)".

I prefer a badge, although I don't really like the current one.

Secret-chest commented 2 years ago

I think it might look a bit nicer if the message count would be shown in parenthesis instead of being a badge. Something like "Messaging (123)".

I agree.

Maybe the addons tab could have one too? "Addons (22)" where 22 is the number of addons on this tab.

Secret-chest commented 2 years ago

I would also like to be able to always open to messages.

BroJac5246 commented 2 years ago

Maybe the addons tab could have one too? "Addons (22)" where 22 is the number of addons on this tab.

That would be unnecessary, though. What would one do with that number?

penguinmoose commented 2 years ago

I think it might look a bit nicer if the message count would be shown in parenthesis instead of being a badge. Something like "Messaging (123)".

I prefer a badge, although I don't really like the current one.

I think the badge should be moved down a pixel or two so that the text in the badge is aligned with "Messages".

Secret-chest commented 1 year ago

I might implement this when I have time.

WorldLanguages commented 1 year ago

Show the number of unread messages on the Messaging tab.

Probably up to 4 characters as a limit? 9998, 9999, and for any number greater than 9999 we can display 999+. We don't want the tabs to overflow in languages with longer words.

Secret-chest commented 1 year ago

Or just ++++.

iqnite commented 8 months ago

I like the idea, but if we include the exact number in the tab, we may need to make the popup bigger: image

Alternatively, showing something like in this mockup should work fine, too:

image
WorldLanguages commented 8 months ago

I think the number we show in our own UI should match the string we set the badge. So, maximum of 3 characters if #7317 is merged.

BlueGoat11 commented 8 months ago

An addition to this add on could be a read messages bottom on the actual messages tab cause I don’t know if it’s just me but its really annoying after looking at the messages for them to still be there.

BlueGoat11 commented 8 months ago

I’m An addition to this add on could be a read messages bottom on the actual messages tab cause I don’t know if it’s just me but its really annoying after looking at the messages for them to still be there. Should this be an issue of it’s own… sorry I don’t know much about GitHub

Secret-chest commented 8 months ago

I think the number we show in our own UI should match the string we set the badge. So, maximum of 3 characters if #7317 is merged.

Why? We have space, why not show more?

iqnite commented 8 months ago

Why? We have space, why not show more?

1) consistency 2) some languages don't have enough space

Secret-chest commented 8 months ago

consistency

Note that Scratch doesn't round numbers.

BroJac5246 commented 8 months ago

consistency

Note that Scratch doesn't round numbers.

Nor do they add commas — their system wasn't designed with large message counts in mind.

Secret-chest commented 7 months ago

Put it in parentheses without styling, otherwise it stands out too much.

mxmou commented 7 months ago

Put it in parentheses without styling, otherwise it stands out too much.

It's meant to stand out - it's the number of unread messages. It could be white or dark gray instead of blue though.

image

image

WorldLanguages commented 7 months ago

I like the gray, I assume the contrast is good enough?

mxmou commented 7 months ago

I like the gray, I assume the contrast is good enough?

There's enough contrast between the badge text and background, but not between the badge and the background of the tab. I don't think that's a problem - the badge isn't an interactive element - but it could be fixed by adding a border.