ScriptLineStudios / waphics.c

A web browser video game library for C.
https://waphicsc.readthedocs.io/en/latest/index.html
MIT License
3 stars 1 forks source link

I Want to Contribute, How Can i Do That? #1

Open sDos280 opened 1 year ago

sDos280 commented 1 year ago

Hi, @ScriptLineStudios. after looking around GitHub I found your project, and I really like its idea.

I would really like to contribute to that project. Are there some conventions that I need to follow to contribute?

some background about me: I am a c/c++/python programmer, I am one of the raylib contributors, and I really like to contribute to new graphic libraries, especially ones that able to run on web

sDos280 commented 1 year ago

for example, one thing I would like to do is refactor the draw function. for example, the waphics_draw_circle uses this expression dist((int)circle.x, (int)circle.y, (int)_x, (int)_y) < circle.r to check if the "current pixel" is in the circle, but instead of doing that you can check if the distance squared is less then the circle's radius squared (circle.x - x)*(circle.x - x) + (circle.y - y)*(circle.y - y) < circle.r * circle.r

sDos280 commented 1 year ago

and i seem to get an error when i try to use the CIRCLE macro #define CIRCLE(x, y, r) waphics_rectangle_new(x, y, r) that seem to be the issue. i think you meant it to be: #define CIRCLE(x, y, r) waphics_circle_new(x, y, r)

ScriptLineStudios commented 1 year ago

Hello! Thanks for pointing out the issues, I was actually just working on fixes for them lol. As you can probably tell, this project is still quite early in development, but I would love contributes :D as for conventions I am quite relaxed.

Thanks for showing interest in the project!

sDos280 commented 1 year ago

thanks for the replay!!

is that will be ok if I will open some GitHub issues regarding some errors/issues that I encountered?

ScriptLineStudios commented 1 year ago

@sDos280 yes that would be great thanks!