Closed TroyKomodo closed 6 months ago
Attention: 588 lines
in your changes are missing coverage. Please review.
Comparison is base (
1e25f4b
) 53.24% compared to head (58010f5
) 52.38%.:exclamation: Current head 58010f5 differs from pull request most recent head 138cecd. Consider uploading reports for the commit 138cecd to get more accurate results
Proposed changes
Adds a generic file upload rest endpoint.
The idea is, you will query GQL and the GQL API will return a token you can use to upload a file to. (Something like a singed URL, except its just a token you put into the Authentication Header). We then query (delete) the token in the database to validate that the token has not already been used (deleted). Once we have everything we need, the database will tell us how we need to handle the uploaded file. Right now all we will support is image uploads for Profile pictures, or banners or whatever. But in future we may allow any file upload and it will all use the same endpoint which makes things nice and simple.
Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
.-.