Closed azlyth closed 10 years ago
This looks great, thanks!
The only thing I changed was adding the width auto style on line 5. Without that, the size set on the Value option (e.g. line 33 in iptunnel.lua) is ignored.
Do you think this could be solved with CSS as well? After all it's a styling issue, isn't it? It'd save us a couple of KB as well :) I'm not so familiar with LuCI's templating and styling, but I'm sure there's something for adding stylesheets.
Anyhow, merging :+1:
I checked and LuCI doesn't seem to have a built in way to add styling (as you can see in that template). I even tried to inject the style as a hack, but things are properly escaped before they hit the page, as they should be. So yeah, we'd have to add a stylesheet or something. I'll look into it. :D
There is a meshbox-bootstrap theme by @dansup. Would you like to use that as a starting template @azlyth? I think more was added to it, but we didn't merge it here.. It's worth looking into. Although the adjustments needed are minor -- they simply exceed the right hemisphere of my brain :)
The only addition that isn't particularly obvious is the addition of luci-cjdns/luasrc/view/cjdns/value.htm. It's basically an exact copy of the default value template in LuCI. The only thing I changed was adding the width auto style on line 5. Without that, the size set on the Value option (e.g. line 33 in iptunnel.lua) is ignored.