Closed dangowrt closed 9 years ago
Thanks :100:
Before I forget: what exactly was the confusion, did browsers refuse to execute the JS?
luci status didn't come up at all on Firefox which refused to display the page and comes up with a huge XML Error message instead, rendering all of luci-admin-full unusable. This was due to cjdns status being included in the overall status view which is shown straight after admin login. It too me a while to figure out that my luci-related problems came from stuff included by luci-app-cjdns.
On Thu, Dec 18, 2014 at 12:43:18PM -0800, Lars wrote:
Before I forget: what exactly was the confusion, did browsers refuse to execute the JS?
Reply to this email directly or view it on GitHub: https://github.com/SeattleMeshnet/meshbox/pull/32#issuecomment-67553528
Mh, I think you're the very first to experience this -- thanks for fixing.
Easy to reproduce with Firefox 34.0.5 on Linux x86_64. No Add-ons installed. Plugins: OpenH264 (Cisco), Gnome Shell Integration Seems like Firefox recently became more strickt when it comes to XML compliancy.
On Thu, Dec 18, 2014 at 01:55:48PM -0800, Lars wrote:
Mh, I think you're the very first to experience this -- thanks for fixing.
Reply to this email directly or view it on GitHub: https://github.com/SeattleMeshnet/meshbox/pull/32#issuecomment-67563877
JavaScript source included in status.htm didn't escape from XML context. Fix that by adding //<![CDATA[ //]]> construct. This is needed so browsers don't get confused (some did).
Signed-off-by: Daniel Golle daniel@makrotopia.org