search

SeattleTestbed / dist

ARCHIVAL: SeattleTestbed's old installer build tool and files
MIT License
0 stars 3 forks source link

stop script does not stop sandboxes... #142

Open JustinCappos opened 10 years ago

JustinCappos commented 10 years ago

The stop script and the uninstall script should stop any executing sandboxes. Right now, they continue to execute even after the node manager, etc. stop executing.

We could potentially create stop files to get the vessels to abort...

JustinCappos commented 10 years ago

There is a potentially related issue here: https://github.com/SeattleTestbed/softwareupdater/issues/47

aaaaalbert commented 10 years ago

Indeed, the stop script only stops the nodemanager and softwareupdater, but not any sandboxes that might be running. See the Linux stop script for example: https://github.com/SeattleTestbed/dist/blob/new_build_v1/linux/scripts/stop_seattle.sh

The most portable way to stop vessels probably is to use their stopfiles. See the vesseldict key "stopfilename". The functionality should go into https://github.com/SeattleTestbed/dist/blob/new_build_v1/stop_all_seattle_processes.py I think, not the shell/BAT script.

(The potential gotcha is that not all vessels necessarily will have stopfiles. We can only be sure for standard installs.)

aaaaalbert commented 10 years ago

Alternatively, we could add a signal handler to the nodemanager to kill all the processes it spawned earlier when it receives SIGTERM. (This would also fix the softwareupdater issue mentioned above.)