Quintus
commented
4 years ago I'm unfamiliar with this new CMake target system, but I trust you know what you're doing. I've always used CMake's XYZ_INCLUDE_DIRS and XYZ_LIBRARIES variables, but apparently this is the new way of doing it...
As for all the .cmake find modules we have in TSC -- they are related to ticket #556. As we have recently dropped cross-compiling support in favour of native compilation with MSYS2, it's likely that we can drop a number of them.
Is there a specific reason why USE_SYSTEM_MRUBY is removed? I remember that muammar wanted to link TSC against the mruby included in Debian rather than our shipped one. The documentation for the option clearly said that mruby version mismatches need to be considered, which is enough of a warning in my opinion. Why take the option away entirely?
Finally, two things for your information (I'll cater for these): First, I think tinyclipboard should be dropped in devel entirely, because there's now sf::Clipboard, which weren't available yet when TSC was ported to SFML. Second, I think I'm going to drop the pod-parser Git submodule and just add the files in themselves. It's unlikely that it'll ever see development outside of TSC.
Ah, and the PR has conflicts with devel now that I merged in release-2.1.0 once more. Would be nice if you could resolve them.
refi64
The main commit is the switch to CMake namespace targets for loading external dependencies, which should fix all the weird build issues associated with the old way.