search

Seedstars / django-react-redux-base

Seedstars Labs Base Django React Redux Project
MIT License
2.66k stars 340 forks source link

Updating to more recent version of django, drf, etc. #115

Open seth4618 opened 5 years ago

seth4618 commented 5 years ago

This boilerplate project is really awesome. I am thinking of using it, but want to make sure my projects start from the updated version of django and rest framework. To check out whether this was possible, I removed all the version numbers from your requirement files and ran the project. I had to change a few things

And, most importantly I had to change the const SERVER_URL in src/static/utils/config.js from localhost to 127.0.0.1 otherwise preflight would fail when trying to login. I am not sure why this change would have to be made, but it would not work without it.

I would have put this all in a pull request, but I thought I would open an issue since I am not sure why I had to change SERVER_URL. Any thoughts? Are you interested in an update to more recent versions?

Here are the updated version from py-requirements/base.py:

Django==2.0.9
django-extensions==2.1.3
django-cors-headers==2.4.0

git+https://github.com/aaronbassett/DisposableEmailChecker

# serve files
whitenoise==4.1.1

# Rest Framework
djangorestframework==3.9.0

# Sentry
raven==6.9.0

# for date processing
python-dateutil==2.7.5

# Logging
git+https://github.com/Seedstars/django-rest-logger.git

django-rest-knox==3.4.0
ckeeney commented 5 years ago

I'd really like a response to this issue. It's hard to want to start a new project based on Django 1.x.

This issue is a more general issue of #111.

casibbald commented 5 years ago

An update would be great.

On 14 Nov 2018, at 21:07, Seth notifications@github.com wrote:

This boilerplate project is really awesome. I am thinking of using it, but want to make sure my projects start from the updated version of django and rest framework. To check out whether this was possible, I removed all the version numbers from your requirement files and ran the project. I had to change a few things

namespaces in url files using path instead of url for some of the urlpatterns including CORS related middleware some settings And, most importantly I had to change the const SERVER_URL in src/static/utils/config.js from localhost to 127.0.0.1 otherwise preflight would fail when trying to login. I am not sure why this change would have to be made, but it would not work without it.

I would have put this all in a pull request, but I thought I would open an issue since I am not sure why I had to change SERVER_URL. Any thoughts? Are you interested in an update to more recent versions?

Here are the updated version from py-requirements/base.py:

Django==2.0.9 django-extensions==2.1.3 django-cors-headers==2.4.0

git+https://github.com/aaronbassett/DisposableEmailChecker

serve files

whitenoise==4.1.1

Rest Framework

djangorestframework==3.9.0

Sentry

raven==6.9.0

for date processing

python-dateutil==2.7.5

Logging

git+https://github.com/Seedstars/django-rest-logger.git

django-rest-knox==3.4.0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Seedstars/django-react-redux-base/issues/115, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHhbwjFAIpwPvu3XxrVa9ywrINXDVxkks5uvGnUgaJpZM4YeYlV.

kooshan75 commented 5 years ago

Is anyone here in charge?!