search

Segfault-Inc / Multicorn

Data Access Library
https://multicorn.org/
PostgreSQL License
697 stars 145 forks source link

Support PostgreSQL 13 #260

Closed df7cb closed 2 years ago

df7cb commented 3 years ago

This patch adds PG 13 compatibility.

I'm submitting it as work in progress because while it passes all regression tests on Debian unstable/amd64, there's some problems that exhibit only on some architecture/distribution combinations, likely because the lnext() handling isn't correct.

It would be nice if someone could have a look if I screwed something up. Thanks!

df7cb commented 3 years ago

Error matrix: https://pgdgbuild.dus.dg-i.net/view/Testsuite-Beta/job/postgresql-multicorn-autopkgtest-beta/

Remi-C commented 3 years ago

Would also be interested by that

ShaheedHaque commented 3 years ago

@df7cb I have looked over the diffs and fwiw, compared them to some notes I made on this a while ago, and they look good. At the time, I did not manage to track down the OID header, but it looks like you nailed that.

I also looked at the autopkg errors. I'm well outside my comfort zone, but the amd64 failure on sid looks like a scripting issue related to pg14, possibly because it was missing. I could not see the script, but perhaps it could be rerun or debugged? Happy to assist with this if I can.

As for the hirsute failure, its not clear to me if has ever run?

luss commented 3 years ago

I have forked this project and created Multicorn 1.4.1. Please take a look at https://github.com/pgsql-io/Multicorn/

I would love it if the segfault-inc folks would reference my fork. I plan to maintain it into the foreseeable future. My versions 1.4.1 supports pg13 and my upcoming version 1.4.2 will also support pg14. I'm sure ya'all have your own favorite FDW that relies on Multcorn; mine is the ElasticSearch FDW (& that's personally why I forked multicorn).

I have binaries for MUlticorn & EsFDW on https://pgsql.io

Please do let me know what other patches make sense to apply (and why)

On Sun, Jul 11, 2021 at 5:43 AM ShaheedHaque @.***> wrote:

@df7cb https://github.com/df7cb I have looked over the diffs and fwiw, compared them to some notes I made on this a while ago, and they look good. At the time, I did not manage to track down the OID header, but it looks like you nailed that.

I also looked at the autopkg errors. I'm well outside my comfort zone, but the amd64 failure on sid looks like a scripting issue related to pg14, possibly because it was missing. I could not see the script, but perhaps it could be rerun or debugged? Happy to assist with this if I can.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Segfault-Inc/Multicorn/pull/260#issuecomment-877770737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHXGR6TPAKZSI2NMCSTTXFRU7ANCNFSM4QDQOP5A .

ShaheedHaque commented 3 years ago

@luss Thanks for the pointer. So that means there is at least this PR, your release and the incomplete patch I was about to dust off interested in moving Multicorn forward. Hopefully, the maintainers will take this as a cue. (I for one would prefer a "standard" pypi.org-hosted release to avoid additional deployment hassle).

luss commented 3 years ago

Yup... I also like the idea of being able to install an up to date multicorn via PIP.

On Sun, Jul 11, 2021 at 10:16 AM ShaheedHaque @.***> wrote:

@luss https://github.com/luss Thanks for the pointer. So that means there are at least this PR, your release and the incomplete patch I was about to dust off interested in moving Multicorn forward. Hopefully, the maintainers will take this as a cue. (I for one would prefer a "standard" pypi.org-hosted release to avoid additional deployment hassle).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Segfault-Inc/Multicorn/pull/260#issuecomment-877807528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMWOHRGK7PEE7ALIAVIOJ3TXGRSVANCNFSM4QDQOP5A .

luss commented 2 years ago

Seems that Segfault is defunct as a company and that this repo is indeed. I have started an inclusive community and repo for Multicorn at https://github.com/pgsql-io/Multicorn. We are focusing on compatibility for the latest vewrsion of PostgreSQL and plan to test with version 10+. Each year we will drop support for PostgreSQL versions that are no longer supported by the core PostgreSQl community.

cpaelzer commented 2 years ago

Thanks @luss I subscribed to the releases in your new repository and look forward to use them once you have a new one.