Selenium-H / Animation-Tweaks

A GNOME Shell Extension to Tweak animations and customize them
GNU General Public License v3.0
66 stars 9 forks source link

Save, Import, Export needs clarification #43

Open auipga opened 3 years ago

auipga commented 3 years ago

Nevertheless profiles need the ability to be renamed to make use of Save/Export/Import.

Sorry for mixing up questions with problems.

Selenium-H commented 3 years ago

Thanks for the detailed description. Yes, this part needs more work. The current implementation is not very intuitive. I'll update once it's done.

For the time being this is how everything works -

Save

* what does it save to? I guess the current settings to the current profile. (could not verify)

It saves extension preferences (everything in Action tab, everything in Profiles -> Application Profiles and everything in Tweaks tab except Shortcut key combination to disable extension ) in selected profile by overriding the selected profile in animationTweaksExtensionProfiles.js file in ~/.config/gnome-shell-extension-animation-tweaks@Selenium-H folder.

  • Export

    • does it export my current settings, the selected profile or everything?

Yes, It exports everything and all profiles (provided the current settings are saved by clicking the Save button). If any changes are done to a particular profile and not saved, they are not exported.

Import

* seems to append.

* I ended up with

  * Default
  * Default_1
  * Default_1_1
  * Default_1_1_1
  * Default_1_1_1_1
  * ...
  * but non of them seems to load my settings (everything is default, custom Application Profiles missing, ...)

It imports any older profiles exported via the Export option. Currently, naming logic is bad. It just appends _1 if it finds duplicate profile names. ( I'll try to implement profile naming options to eliminate this). However, if the settings were saved and exported, it should be able to load the previous settings.

* but non of them seems to load my settings (everything is default, custom Application Profiles missing, ...)

After making changes to the preferences, please save the settings using Save button. Then export it.

auipga commented 3 years ago

Thank you for the fast answers.

Import/Export What do you think about writing only a single profile to a file? While exporting I could change the name from "my super crazy overkill profile_1_1" to "Crazy by auipga" which is also nice for sharing purposes. When importing, the loaded file/profile suggests this value which can be accepted or changed. In this window you then could enforce unique names.