search

Self-Evident / OneFileCMS

A single file cms - all in one file!
http://onefilecms.com/
165 stars 57 forks source link

OFC won't run under PHP 5.2.6-1 #4

Closed codeless closed 12 years ago

codeless commented 12 years ago

OFC is unable to run under PHP 5.2.6-1 on a Linux machine. I have no access to the error-log. Can you confirm your OFC-test on PHP 5.2.17? Is everything running correctly there?

Self-Evident commented 12 years ago

No, there seems to be an issue with PHP < 5.3, and how I implemented the built in language settings. I think it's related to how I used return in the language function: return ' language_string1 = "some text" language_string2 = "some more text" ';

Self-Evident commented 12 years ago

Issue resolved. However, the fix that was used may not be the final solution, but it works for now. (I hope)

Self-Evident commented 12 years ago

Fixed.  I didn't test it out on a 5.2 version before the commit, since it worked on PHP 5.3.  I will from now on, however.  

About your pull request, I apologize that I don't have time to check it out right now, but I'll get to it.  One thought, however, if you haven't done so lately, is that you may want to re-fork from my repo, or otherwise sync up to it, because I think some of your earlier changes that I have already manually added are coming thru on the current request.  

Oh yea - is your German translation done?  I don't mean to ask as though it should be, I'm just curious because it looked like there were some items still in English, and I don't want to commit it until it's ready.

Anyway, thanks for the efforts.

Cheers!

----- Original Message ----- From: codeless Sent: 07/13/12 05:10 AM To: Self-Evident Subject: [OneFileCMS] OFC won't run under PHP 5.2.6-1 (#4)

OFC is unable to run under PHP 5.2.6-1 on a Linux machine. I have no access to the error-log. Can you confirm your OFC-test on PHP 5.2.17? Is everything running correctly there?

Reply to this email directly or view it on GitHub: https://github.com/Self-Evident/OneFileCMS/issues/4