search

Semantic-Org / Semantic-UI

Semantic is a UI component framework based around useful principles from natural language.
http://www.semantic-ui.com
MIT License
51.11k stars 4.94k forks source link

[Icons] Icons removed in FontAwesome 5 are wrong #6231

Open NoisyFlake opened 6 years ago

NoisyFlake commented 6 years ago

Some icons that were removed in FontAwesome 5 but were kept for compatibility reasons point to the wrong icons. Example:

i.icon.resize.horizontal has content: "\f337" which correlates to i.icon.envelope.open.outline. Instead it shoud point to the new i.icon.arrows.alternate.horizontal which has content: "\f697".

Other classes I found that point to the wrong icon:

cloud.download cloud.upload disk.outline exchange heart.empty hourglass.zero protect resize.horizontal resize.vertical star.empty

The rest seems to be mostly fine (or as good as possible as not every old icon has a fitting replacement).

rtarnaud commented 6 years ago

The icons i.icon.arrows.alternate.horizontal and i.icon.arrows.alternate.vertical do not seem to work in 2.3.0. They indeed point to the right values (\f337 and \f338 respectively) according to the FA5 cheatsheet. Any idea why?

NoisyFlake commented 6 years ago

@rtarnaud: This is already fixed in v2.3.1 (which is deployed to the docs page), but it's not officially released yet.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.