search

Semro / syncwatch

Browser extension to watch videos together
MIT License
135 stars 19 forks source link

fix: drop url strict comparison #47

Closed jstsmthrgk closed 6 months ago

jstsmthrgk commented 8 months ago

Currently https://media.ccc.de does not work, this is because the player changes the fragement part of the url (the part after #) whenever it gets paused. It would be nice if the fragment part of the url would just be ignored for media.ccc.de (or possibly all the time? I don't know which is better...)

Semro commented 6 months ago

It would be great to drop strict URL comparison at all. We can depend on tab.id, but we should stop sync if user goes to a new URL in syncing tab. Probably requires some indication what tab in sync.

Semro commented 6 months ago

After #50 changing tab's URL without reloading shouldn't interrupt syncing. If you go to other URL in syncing tab, then syncing would be stopped, because we don't want to give access to control other site, that not been shared.