search

Seneca-ICTOER / Intro2C

Seneca College IPC144 Course Notes
https://ipc144.sdds.ca
Other
7 stars 52 forks source link

Replace pictures with mermaid diagrams #177

Closed Genne23v closed 1 year ago

Genne23v commented 2 years ago

This PR demo #173 or potentially fixes #173. I have developed a proof of concept to have a go-ahead for mermaid.js diagrams. mermaid is a great graph rendering tool for software graphs, but I guess it may not be suitable for general diagram as it's not easy to customize such as node gaps and text alignment inside the shape. Please let me know if you have any feedback. I will quickly push more based on feedback.

Thank you

humphd commented 2 years ago

@Genne23v can we get a preview of this (screenshots or hosted version or something) so it's easier to review?

Also, do you want to update to resolve the merge conflict you have? You can squash your commits at the same time, we only need 1.

Genne23v commented 2 years ago

Here are the photos of mermaid diagrams. I like mermaid when drawing a complex diagrams, but not so effective when drawing a primitive one due to lack of customization features. Let me know if you have any feedback.

Screenshot 2022-11-15 at 10 48 53 AM

Screenshot 2022-11-15 at 10 49 03 AM

Screenshot 2022-11-15 at 10 49 11 AM

humphd commented 2 years ago

@devils2ndself can you do another round of reviews on the changes @Genne23v made here?

Genne23v commented 1 year ago

Just curious what's going on. Is it going to be merged or need more work?

humphd commented 1 year ago

Tagging @CameronGray1210 in, since he's the one who merges/manages this repo.