search

SenexCrenshaw / xTeVe

M3U Proxy and EPG aggregator for Plex DVR and Emby Live TV
MIT License
87 stars 10 forks source link

Change-to-github-api #19

Closed SenexCrenshaw closed 1 year ago

cnorton-webdev commented 1 year ago

@SenexCrenshaw nice, I wasn't aware you could use the GitHub API without a token to list all the files in a repository, but that makes it much cleaner and easier to iterate over. 👍🏼

cnorton-webdev commented 1 year ago

In regards to:

Excellent! I have a few suggestions

  1. An option to prefer M3U logos if they are set
  2. Logo URL in the interface. Wasn't obvious I could remove the existing text and type to complete. It works great, just didn't seem obvious. Maybe note "Logo URL: URL or type to search" ... something like that
  3. The ability to search by country. Maybe a pull down list of countries at the top of the mapping page which would be added to the autocomplete filter
  4. The logo json creator is slow. I had another PR I was playing with that downloads using the GitHub API. Maybe you can incorporate this: logo.go
  5. func ignoredFiles. I think this can be cleaned up as well
  6. Maybe a filter in the mapping page for missing Logos only?

Thanks for a great PR. Let me know your thoughts.

Sounds good, will look into getting these implemented, thanks for the feedback.

SenexCrenshaw commented 1 year ago

I am just about done those few items above. You can check out the PR to see where it is going

SenexCrenshaw commented 1 year ago

Should be good to go now /releases/v.2.5.2