search

SenteraLLC / ulabel

A browser-based tool for image annotation
MIT License
23 stars 5 forks source link

Linting / Precommit Hooks #103

Open joshua-dean opened 1 year ago

joshua-dean commented 1 year ago

Could use some standardization and some dev environment hook setups to keep the code structure clean

joshua-dean commented 1 day ago

@TrevorBurgoyne @csolbs24 I'm thinking we go with ESLint and prettier, with both being ran as pre-commit hooks. Any qualms with these? If there's something we'd rather use, I'm open to it. I'll have a PR with the formatting changes so that we can split hairs over linting/formatting rules before anything is official.

joshua-dean commented 1 day ago

I opened #175 as a draft. It uses husky as I liked it's terminal outputs better than the pre-commit on npm (which is apparently different from the python one).

ESLint finds 232 errors so it might be wise to merge it and fix files as they're edited. Thoughts?