SerGreen / Appacker

Tool for making single .exe application packages
235 stars 29 forks source link

Adding Compression #22

Open modz2014 opened 2 years ago

modz2014 commented 2 years ago

hi any chance of adding compression when packed

SerGreen commented 2 years ago

I don't have plans for this, maybe if someone else figures out how to add it.

modz2014 commented 2 years ago

thats what i was looking but there is not much where i could add it

SerGreen commented 2 years ago

It says that the ValueTuple type is missing, which was introduced in .NET Framework 4.7, Appacker project is also targeting .NET Framework 4.7.2. So the error might mean that you should update your Visual Studio and install .NET 4.7.2 SDK.

пт, 25 нояб. 2022 г. в 04:43, modz2014 @.***>:

tried to compile it i have errors [image: Capture] https://user-images.githubusercontent.com/25472227/203889760-c8164275-4e11-47eb-a5da-4c32a93cef2c.PNG

— Reply to this email directly, view it on GitHub https://github.com/SerGreen/Appacker/issues/22#issuecomment-1326964583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6QU5LQVLZ7NAMESWMZYJLWKARTTANCNFSM6AAAAAASKID52Q . You are receiving this because you commented.Message ID: @.***>

modz2014 commented 2 years ago

have fixed the problem also can you point in the direction to add compression type ect

SerGreen commented 2 years ago

Probably you want to change Packer Program.cs and Unpacker Program.cs in PackerShared and UnpackerShared projects respectively. Change the packing program in a way so that it doesn't append all the files directly to the unpacker.exe binary file, but instead maybe compresses all the files using 7zip or something and only then it appends the archive to the unpacker.exe file. And the unpacking program, respectively, first should extract the archive from itself and then unzip the archive into a temp folder.

пт, 25 нояб. 2022 г. в 07:54, modz2014 @.***>:

have fixed the problem also can you point in the direction to add compression type ect

— Reply to this email directly, view it on GitHub https://github.com/SerGreen/Appacker/issues/22#issuecomment-1327050398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6QU5KVXUVFORLSTMEDBNDWKBIBZANCNFSM6AAAAAASKID52Q . You are receiving this because you commented.Message ID: @.***>

modz2014 commented 2 years ago

but creating one exe like it does is alot better and more neat instead of having two files

SerGreen commented 2 years ago

It shouldn't be two files, the archive should be attached to the end of the packed exe (open exe as a binary stream in append mode and just write the archive to it).

Currently Appacker attaches all of the target files to the end of a small utility exe, which becomes a packed application. That small utility can extract target files from the end of its own exe when you run it. So it should be possible to make Appacker attach the entire archive to the end of the utility exe instead, and make that utility unzip the archive after extracting it from its own exe.

пт, 25 нояб. 2022 г. в 08:23, modz2014 @.***>:

but creating one exe like it does is alot better and more neat instead of having two files

— Reply to this email directly, view it on GitHub https://github.com/SerGreen/Appacker/issues/22#issuecomment-1327066506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6QU5JLUPTIVCKNKQXIR5DWKBLMNANCNFSM6AAAAAASKID52Q . You are receiving this because you commented.Message ID: @.***>