Open thomas694 opened 1 year ago
You need to add the submission ID that makes this fail, that's how we write the tests.
This ID/link throws the error too:
bdfr download --link https://www.reddit.com/user/billbilljr/comments/pe7jil Z:/Reddit
Comments can't be downloaded with a module like this. You need to add the logs for a run that fails, or this issue will have to be closed. We can't do anything without those.
Description
I got an exception downloading a submission which ID/link I'll keep unposted.
Example exception:
Opening the post in the browser it says:
A crash happens if the YT downloader doesn't return data.
The
get_video_data
call in line 81 can returnNone
, so line 82 should check if result is not None. https://github.com/aliparlakci/bulk-downloader-for-reddit/blob/8c293a46843c818bea2c2013db38191867993a14/bdfr/site_downloaders/youtube.py#L80-L82So if someone likes to take the solution, add a test method and create a PR, feel free.