Sereni / Simply-Love-SM5-Vertical

Simply Love on vertical screens
MIT License
13 stars 3 forks source link

Should Pacemaker be hidden when Do Not Judge Me is enabled? #49

Closed Roujo closed 4 years ago

Roujo commented 4 years ago

I recently pulled in the changes which placed the Pacemaker correctly on-screen (yay!) and I was surprised to see it when I played using Do Not Judge Me today. I understand that Do Not Judge Me mostly affects the judgement screen, but I was expecting it to also hide the Pacemaker since it hides stuff like the best score at song selection. I'm not sure what the intended behavior is here, so before working on it I'd like to know your opinion on this.

Should Do Not Judge Me suppress the display of Pacemaker and other scoring-related gameplay extras when it's on, or is it working as intended and the player should disable those elements manually?

Sereni commented 4 years ago

yeah definitely, great catch! I forgot about it when making that change