Update java to v17 and update file chooser

SergelsOrg / csv2tex

Tool to replace placeholders in tex-files

GNU General Public License v3.0

5 stars 0 forks source link

Update java to v17 and update file chooser #131

Open ArchibaldBienetre opened 1 year ago

ArchibaldBienetre commented 1 year ago

The Java module system is quite... buggy and brittle with Java 11, it seems.

I'm hoping for improvements with the upgrade (e.g. removing several workarounds).

ArchibaldBienetre commented 7 months ago

Can't seem to make progress somehow.

It seems

I can't turn "src/test" into a separate module that could require the stuff from "src/main", which would solve the remaining build issues with ./gradlew :compileTest
I can't leave things as they are , compile fails because classes from "src/main" are not found by for the "src/test" code

I'm thinking about creating a whole separate thing for tests, like we did for the integration tests - because it seems to work there.

This is super weird.

ArchibaldBienetre commented 7 months ago

Can't seem to make progress somehow.

It seems

I can't turn "src/test" into a separate module that could require the stuff from "src/main", which would solve the remaining build issues with ./gradlew :compileTest

I can't leave things as they are , compile fails because classes from "src/main" are not found by for the "src/test" code

I'm thinking about creating a whole separate thing for tests, like we did for the integration tests - because it seems to work there.

This is super weird.

Now I get it. I don't need a module definition there, it's just a source set, or something

ArchibaldBienetre commented 7 months ago

@DonMischo no need to be super fast with the review here

I mainly hand this to you for review so I won't merge it without your consent.

I just don't know if I can assume that your physical setup has Java 17, yet.