Severson-Group / AMDC-Firmware

Embedded system code (C and Verilog) which runs the AMDC Hardware
http://docs.amdc.dev/firmware
BSD 3-Clause "New" or "Revised" License
33 stars 6 forks source link

Fixes for new Timing Manager mode #401

Closed codecubepi closed 4 months ago

codecubepi commented 5 months ago

Addresses #399

This PR includes some important timing/Timing Manager fixes:

This comment on the v1.3 WIP Pull Request has the remaining items before we release.

codecubepi commented 5 months ago

We recently merged #400 in v1.3-staging, so fix-tm-mode got rebased and force-pushed.

codecubepi commented 5 months ago

@npetersen2

I think this is ready for a proper review and hopefully a merge into v1.3-staging, so I'll remove the Draft status. Since a fix has not been found yet for the sensor enable/disable bug, that has been split off into a new issue: #402

Please read the top comment on this PR conversation for a full list of changes in this PR.

npetersen2 commented 4 months ago

Let's get this merged to v1.3-staging so @anirudhupadhyaya code can point to the latest v1.3-staging branch