Closed codecubepi closed 4 months ago
We recently merged #400 in v1.3-staging
, so fix-tm-mode
got rebased and force-pushed.
@npetersen2
I think this is ready for a proper review and hopefully a merge into v1.3-staging
, so I'll remove the Draft status. Since a fix has not been found yet for the sensor enable/disable bug, that has been split off into a new issue: #402
Please read the top comment on this PR conversation for a full list of changes in this PR.
Let's get this merged to v1.3-staging
so @anirudhupadhyaya code can point to the latest v1.3-staging
branch
Addresses #399
This PR includes some important timing/Timing Manager fixes:
uint32_t
todouble
and adding some tolerance to the elapsed time check to account for some variation in thedouble
values.trigger
which now flushes the duty ratios required theall_done
signal to be high, but that required at least one sensor to be enabled. The fix was to remove this unnecessary qualification.expected_tick_delta()
function in the timing manager, which calculates the expected time between scheduler interrupts, based on the user's PWM switching frequency, alignment settings, and enabled sensors. This is used in place of the real-timeget_tick_delta()
function where we do not need real-time data.trigger
s sent. This value can be LOGged or retrieved via the command interface.main()
, as to not overwrite anything the user would initialize in theirapp_init()
function.This comment on the
v1.3
WIP Pull Request has the remaining items before we release.