SforAiDl / decepticonlp

Python Library for Robustness Monitoring and Adversarial Debugging of NLP models

MIT License

15 stars 10 forks source link

Update shuffle and swap #36

Closed parantak closed 4 years ago

parantak commented 4 years ago

shuffle and swap have been merged

codecov[bot] commented 4 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.56%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   88.69%   89.25%   +0.56%     
==========================================
  Files           5        5              
  Lines         115      121       +6     
==========================================
+ Hits          102      108       +6     
  Misses         13       13

Impacted Files	Coverage Δ
decepticonlp/transforms/perturb.py	`81.15% <100.00%> (+1.79%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 683cdba...9e59c6d. Read the comment docs.

parantak commented 4 years ago

@someshsingh22 and @rajaswa , could you help me with this? I added the unit tests and the formatting's been done. Am I missing something?

someshsingh22 commented 4 years ago

I dont exactly know but there must be some problem in the coverage of unit cases The perturb.py shows a hit in coverage, check the details -> files -> browse files where coverage is decreasing Its failing there maybe @Sharad24 can help more

parantak commented 4 years ago

@someshsingh22 , could it possibly be that we'd have to add a test case for when ignore=True? Though, that did not pose an issue previously

Sharad24 commented 4 years ago

Also, you can run pytest --cov='./decepticonlp' --cov-report=html followed by open htmlcov/index.html to see code coverage locally.

parantak commented 4 years ago

@Sharad24 , could you see to the last test and help out. I fixed the overlapping test cases and I will fix the documentation soon. Thanks.

parantak commented 4 years ago

All tests are done. Thanks.

Sharad24 commented 4 years ago

Great!

On 11-May-2020, at 2:48 PM, Parantak Singh notifications@github.com wrote:

All tests are done. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SforAiDl/decepticonlp/pull/36#issuecomment-626580718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ52WE4ONMQLA7AYJK3RQ67HHANCNFSM4M5VIFEA.