ShaastraWebops / Frontend-2016

Frontend for the Shaastra-2016 website
http://www.shaastra.org
3 stars 1 forks source link

Menu bar #7

Closed chinnichaitanya closed 8 years ago

chinnichaitanya commented 9 years ago

This might take some time. The data is not static here. Again we use $http requests to get the events, workshops etc.

Menu is used in all pages so this must be modular.

Refer 13.jpg and 14.jpg in the drive folder.

AnandJM commented 9 years ago

acknowledged On 7 Jun 2015 04:19, "Chinni Chaitanya" notifications@github.com wrote:

Assigned #7 https://github.com/ShaastraWebops/Frontend-2016/issues/7 to @AnandJM https://github.com/AnandJM.

— Reply to this email directly or view it on GitHub https://github.com/ShaastraWebops/Frontend-2016/issues/7#event-324453616 .

chinnichaitanya commented 9 years ago

Any updates ?

AnandJM commented 9 years ago

Right now I don't have a good net connection...will start working on 12th On 10 Jun 2015 01:53, "Chinni Chaitanya" notifications@github.com wrote:

Any updates ?

— Reply to this email directly or view it on GitHub https://github.com/ShaastraWebops/Frontend-2016/issues/7#issuecomment-110494213 .

chinnichaitanya commented 9 years ago

Any updates ?

AnandJM commented 9 years ago

made menu page but need to put the jquery in the angularjs controller file

chinnichaitanya commented 9 years ago

@AnandJM Any updates on this ??

AnandJM commented 9 years ago

Converted to angularjs and included social media icons

chinnichaitanya commented 9 years ago

@AnandJM A few changes,

Make an update after completing those.

chinnichaitanya commented 9 years ago

@AnandJM Any updates ??

AnandJM commented 9 years ago

tried to make it accordion using slideUp() and slideDown() in jquery but when it was put in the angular directive...it goes up and down twice due to some problem. ...trying to fix that On 6 Jul 2015 21:14, "Chinni Chaitanya" notifications@github.com wrote:

@AnandJM https://github.com/AnandJM Any updates ??

— Reply to this email directly or view it on GitHub https://github.com/ShaastraWebops/Frontend-2016/issues/7#issuecomment-118928204 .

sumanasusmitha commented 9 years ago

Updates?!

AnandJM commented 9 years ago

made the accordion using css. Included another folder with the jquery version. The jquery one slides up and down more than once on each click which is a problem.If this can be fixed i feel that this could be a better solution than using css. Please look into this and suggest solutions if any.

chinnichaitanya commented 9 years ago

@sumanasusmitha ?

chinnichaitanya commented 9 years ago

Ok the first one looks good. But it only occurs on clicking on the right arrow. Ideally, the animation should be happening on clicking on the bar itself. Remember performance of CSS > performance of JavaScript.

AnandJM commented 9 years ago

okay will modify it to make it work for the whole bar On 27 Jul 2015 19:47, "Chinni Chaitanya" notifications@github.com wrote:

Ok the first one looks good. But it only occurs on clicking on the right arrow. Ideally, the animation should be happening on clicking on the bar itself. Remember performance of CSS > performance of JavaScript.

— Reply to this email directly or view it on GitHub https://github.com/ShaastraWebops/Frontend-2016/issues/7#issuecomment-125221941 .

AnandJM commented 9 years ago

made it for the whole bar now

chinnichaitanya commented 9 years ago

@AnandJM

AnandJM commented 9 years ago

Added hamburger and scroll

chinnichaitanya commented 9 years ago

@AnandJM Good work! But I see on clicking the close button, the menu just hides. There is no transition or anything like when it appears. So make a transition on closing the menu and put an update. The rest looks awesome.

AnandJM commented 9 years ago

new update with social icons outside and top menubar

chinnichaitanya commented 9 years ago

@sumanasusmitha @sai-akshaya Can you look into this ?

sai-akshaya commented 9 years ago

Great job (y). Seems fine to me

chinnichaitanya commented 9 years ago

@AnandJM A few things,