search

SharePoint / PnP-JS-Core

Code moved to https://github.com/pnp/pnpjs. This repository is archived.
Other
379 stars 231 forks source link

copyTo should it create a new version in destination library? #737

Closed trillian74 closed 6 years ago

trillian74 commented 6 years ago

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the Developer Guide to see if your question is already addressed there. This will help us ensure our documentation covers the most frequent questions.

Category

[ ] Enhancement

[ ] Bug

[X ] Question

Version

Please specify what version of the library you are using: [ 3.0.5 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

pnp.sp.web.getFileByServerRelativeUrl(element.File.ServerRelativeUrl).copyTo(listInfo.RootFolder.ServerRelativeUrl + /${element.File.Name}, true) shouldn't this update the version in destination library when the library has major fileversion versioning in place?

Observed Behavior

It doesn't - i just copies it

Steps to Reproduce

Copy from a library to a desitnation library with versionsupport for only major file versions

patrick-rodgers commented 6 years ago

Hi @trillian74 - the library just call the underlying REST method so will follow that behavior. Is the issue you expect the version to change from say 2 to 3 when it is copied and it stays 2?

trillian74 commented 6 years ago

Yes, that is the situation. I work around it now with uploading new content to destination, but it would be easier just to say copy to

Ole

man. 26. feb. 2018 kl. 16:05 skrev Patrick Rodgers <notifications@github.com

:

Hi @trillian74 https://github.com/trillian74 - the library just call the underlying REST method so will follow that behavior. Is the issue you expect the version to change from say 2 to 3 when it is copied and it stays 2?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/PnP-JS-Core/issues/737#issuecomment-368532341, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFlYmZ3dHTjRdbWSi_xszLXod_7Jym9ks5tYsgkgaJpZM4SQHtM .

patrick-rodgers commented 6 years ago

Having had a look at this it is how the underlying API operates so nothing for us to change here. Unfortunate it doesn't work exactly as you'd like but so it goes. Thanks for your interest in the library and let us know if you have further feedback.

trillian74 commented 6 years ago

No worries, and i love pnp

fre. 2. mar. 2018 kl. 16:39 skrev Patrick Rodgers <notifications@github.com

:

Closed #737 https://github.com/SharePoint/PnP-JS-Core/issues/737.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/PnP-JS-Core/issues/737#event-1501395685, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFlYlKBYqGt33cjfMeuMxq1XN0FMFTHks5taWepgaJpZM4SQHtM .