Fix SVG debug output - Githubissues

Shared-Reality-Lab / IMAGE-browser

IMAGE project browser extensions & client-side code

Other

2 stars 0 forks source link

Fix SVG debug output #313

Closed jaydeepsingh25 closed 1 year ago

jaydeepsingh25 commented 1 year ago

The resizing of SVG output has introduced the following issues:

The SVG output for depth map is distorted, It is not being resized to original graphic size
The aspect ratio of the graphic is disturbed during resizing. This should remain intact.

jaydeepsingh25 commented 1 year ago

@emmanuelwilson please verify if the issue for depth map svg is fixed now. You can test on nightly extension. @jeffbl , I have also fixed image-resizing to maintain aspect ratio as we discussed. Please verify and let me know if any further changes are required.

emmanuelwilson commented 1 year ago

@jaydeepsingh25 Is there something I need to do to have the nightly extension? Or is that the test extension? I don't think I have the right version as I am still seeing the same problems as before and the aspect ratio is still off. I'm excited to see it the result!!

jeffbl commented 1 year ago

Nightly extension link is pinned in slack #general.

emmanuelwilson commented 1 year ago

@jaydeepsingh25 Can confirm that the nightly build works! Great job!!! Thank you for fixing it!

jeffbl commented 1 year ago

Already closed, but @jaydeepsingh25 thanks for doing this - tested with nightly extension, and maintaining aspect ratio makes this much, much better.