search

Shared-Reality-Lab / IMAGE-server

IMAGE project server components
Other
2 stars 7 forks source link

Caching doesn't serve from cache until third request #855

Open jeffbl opened 4 months ago

jeffbl commented 4 months ago

restoreunstable to clear cache

Go to a photo on IMAGE homepage Get IMAGE rendering Note in logs it is storing it in cache

Get rendering for same photo NOTE: stores results in cache EXPECT: serves results from cache since it just stored them

Get rendering for same photo NOTE: correctly serves from cache

Get IMAGE rendering for a photo2 (different photo) NOTE: stores in cache

Get IMAGE rendering for photo2 NOTE: correctly serves from cache

Interpretation: once one photo is cached successfully twice, future photos cache correctly on first try

Go to map, e.g. https://developers.google.com/maps/documentation/embed/get-started Interpret this map with IMAGE NOTE: stores autour results in cache

Interpret this map with IMAGE NOTE: stores again in cache EXPECT: serves from cache since it should already be stored

Interpret this map with IMAGE NOTE: serves from cache (correct)

So other request types or something with which preprocessors are getting run (or some other issue) means that the first time things are cached, they may or may not "stick" the first time, but work after being cached a second time.

EXPECT: Caching is successful the first time, and second request reliably returns results from cache.

jeffbl commented 4 months ago

moving into sprint for fix. It is suspicious that this might cause other problems since we don't understand the root cause.

jeffbl commented 1 month ago

@jaydeepsingh25 I cannot reproduce this any longer, and neither can @shahdyousefak. It always worries me when a problem "fixes itself" but we can't really follow up on this unless we can reproduce it. I'm not aware of any code changes that would have altered this. @jaydeepsingh25 can you do some brief tests, and if you no longer see it either, we can close this as resolved, and reactivate if we see it again...

jaydeepsingh25 commented 1 month ago

I am able to reproduce the issue on unicorn by above mentioned steps.

jeffbl commented 1 month ago

I completely forgot that this was per media type, not for each individual photo, so this definitely still reproduces, but is much more minor of an issue than if it was the first of each media type. @shahdyousefak probably worth no more than an hour or so of investigations just to be sure this isn't indicating a larger issue, but if much longer than that, recommend returning to backlog to focus on higher priority items.