search

SharpAdb / AdvancedSharpAdbClient

AdvancedSharpAdbClient is a .NET library that allows .NET, Mono and Unity applications to communicate with Android devices. It's improved version of SharpAdbClient.
https://sharpadb.github.io
Apache License 2.0
203 stars 54 forks source link

Make methods more thoroughly asynchronous #43

Closed sdijoseph closed 1 year ago

sdijoseph commented 1 year ago

I used the Socket.SendAsync and Socket.ReceiveAsync methods in .NET6+ to make a lot of the code more "async all the way down". I put them behind #if NET6_0_OR_GREATER directives and tried to integrate the new methods as cleanly as possible.

Also added InstallAsync method that uses the new async methods.

wherewhere commented 1 year ago

So why should net6+?

sdijoseph commented 1 year ago

So why should net6+?

Ah, I mistakenly thought SendAsync was only supported in .NET6+, I didn't know about SocketTaskExtensions. This implementation is much better.