Shatur / neovim-ayu

Ayu theme for Neovim.
GNU General Public License v3.0
435 stars 45 forks source link

Nvimtree color change does not actually reflect in neovim #43

Closed Justas-Lapiene closed 2 months ago

Justas-Lapiene commented 2 months ago

Greetings,

I have tried to change the colors of the folders to something a little bit more distinguishable, because strong orange when git dirty against lighter orange is a little bit hard to see. My config is :

return { "Shatur/neovim-ayu", config = function() local colors = require("ayu.colors") colors.generate(false)

require("ayu").setup({
  overrides = function()
    return {
      NvimTreeFolderIcon = { fg = colors.string },
      NvimTreeFolderName = { fg = colors.string },
      NvimTreeGitDirty = { fg = colors.string },
      MatchParen = { fg = colors.string, bg = colors.bg, bold = true },
    }
  end,
})

end, }

If I run :source $VIMRUNTIME/syntax/hitest.vim I can indeed see that the correct highlighting groups have been updated to colors.string, but neovim still reflects their original colors:

image
Justas-Lapiene commented 2 months ago

Might I be targeting the wrong color groups?

Justas-Lapiene commented 2 months ago

Love the colorscheme btw

Shatur commented 2 months ago

Might I be targeting the wrong color groups?

It could be the case. Your configuration looks correct. Try asking Nvimtree author. We also may want to adjust colors in the theme by default to make it look nicer.

Justas-Lapiene commented 2 months ago

Understood. Will reach out to the nvimtree author. Do you have any idea when will you be implementing the changes?

Shatur commented 2 months ago

Do you have any idea when will you be implementing the changes?

Decide on colors and submit a PR with before and after. If it looks objectively nicer (like no duplicated colors), I will merge :)

Justas-Lapiene commented 2 months ago

I just realized I am using neotree and not nvimtree, does that change anything?

Decide on colors and submit a PR with before and after. If it looks objectively nicer (like no duplicated colors), I will merge :)

If I manage to get this working I will definitely give it a shot

Shatur commented 2 months ago

I just realized I am using neotree and not nvimtree, does that change anything?

Yes, I don't think that NvimTreeFolderIcon will work for neotree :laughing: Check which colors are used by nvimtree and submit a PR.

Justas-Lapiene commented 2 months ago

figured it out. Thanks for your patience! Will adjust it in the future a bit and raise a PR.

Shatur commented 2 months ago

Great!