Sheemo / pe

0 stars 0 forks source link

Invalid dates are allowed #4

Open Sheemo opened 1 year ago

Sheemo commented 1 year ago

When executing the command add_task n/Celebrate Lucas Birthday d/29/02/2023, this date is invalid as 2023 is not a leap year. However, the command successfully runs, with an added date of 28 February 2023. This should definitely not be allowed and an error message should be printed for invalid dates. This behavior also happens for dates like 31/04/2023.

For a task, the user could have simply made a mistake, but if the command gets executed, the user could potentially misremember dates of tasks which makes the application unreliable.

image.png

image.png

nus-pe-script commented 1 year ago

Team's Response

We agree that this is an issue with our application, however we disagree that this issue is High, should be at most low as this flaw does not make the application unusable for most users and it is a very rare occurrence 0.2% every 4 yrs for something like a leap year date. You can simply edit these invalid dates to valid ones using the edit command

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: I agree that it is uncommon, but I believe it is still common enough to warrant a Medium severity. The example I provided of 29/02/2023, was just one example, whereas dates like 31/04/2023, 31/06/2023 are all accepted but should not be. While the onus should partially be on the busy home business owner to verify that the input details are correct, I believe the app should minimally tell the user that an invalid date was entered, and not expect the user to use the edit command to fix the issues.