Sheemo / pe

0 stars 0 forks source link

Incorrect error message for invalid dates #5

Open Sheemo opened 1 year ago

Sheemo commented 1 year ago

When executing the command add_task n/My Invalid Birthday d/32/03/2023, the error message simply says Task deadline should only contain numeric values in the format "DD/MM/YYYY" and it should not be blank.

image.png

However, my input conforms to the format, just that my date is invalid. The error message should be more detailed in saying that the date is invalid.

soc-se-bot commented 1 year ago

Team's Response

This is a duplicate of #303. The current error message simply grouped invalid dates under dates with the wrong format, which can be too general. We agree that the error message could have been more specific. However, we think that it is a feature flaw that involves the specificity of error messages instead of a functionality bug.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message for date format is not specific

Steps to reproduce:

  1. add_task n/Buy cookie cutter d/20/13/2023

Screenshot 2023-04-14 at 2.35.30 PM.png

  1. add_task n/Buy cookie cutter d/30/2/2023

Screenshot 2023-04-14 at 2.35.16 PM.png

The two errors above are different, the first is format error while second is input invalid error, but they are not addressed or differentiated.


[original: nus-cs2103-AY2223S2/pe-interim#258] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that we could have differentiated the error message for different errors. The error message simply categorized invalid dates as dates with the wrong format, which makes it too ambiguous.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]