search

ShekarMudaliyar / social_share

Flutter package to share images/videos/text on social media
https://pub.dev/packages/social_share
MIT License
112 stars 191 forks source link

[New Features] I've added some new features in this PR #116

Open dpacchi opened 2 years ago

dpacchi commented 2 years ago

Hi,

I've added some new features to this asset in this PR that hopefully will get approved, hopefully you'll find it useful!

All this features were tested in both iOS and Android

@ShekarMudaliyar

Screenshot_2022-11-03-12-41-37-006_com shekarmudaliyar social_share_example

DennisAshford commented 2 years ago

This sounds like an excellent (and soon to be required) update. Hopefully it is approved so we can implement the App ID. It would be great if the Read Me is also updated to reflect these new requirements, which I was unaware of.

simplenotezy commented 2 years ago

Yeah, let's get this merged so we can include the facebook app id for instagram stories starting from december already

DennisAshford commented 2 years ago

@dpacchi unfortunately looks like this package may be abandoned, which is a shame given how many people seem to use it from the ratings. I tried pointing to your branch(which seemed to work given the required App ID attribute), but I cannot compile/build on iOS or Android. Here is the error from XCode (note it works fine for the original package). Is your branch public? Or any idea where this may be coming from?

2022-11-21 08:40:49.152 xcodebuild[24455:252580] DVTPortal: Service '<DVTPortalViewDeveloperService: 0x7ff2032607d0; action='viewDeveloper'>' encountered an unexpected result code from the portal ('1100') 2022-11-21 08:40:49.152 xcodebuild[24455:252580] DVTPortal: Error: Error Domain=DVTPortalServiceErrorDomain Code=1100 "Your session has expired. Please log in." UserInfo={payload={ creationTimestamp = "2022-11-21T13:40:49Z"; httpCode = 200; protocolVersion = QH65B2; requestUrl = "https://developerservices2.apple.com/services/QH65B2/viewDeveloper.action"; responseId = "f936065d-b15f-4c1f-9151-0282c387d779"; resultCode = 1100; resultString = "Your session has expired. Please log in."; userLocale = "en_US"; userString = "Your session has expired. Please log in."; }, NSLocalizedDescription=Your session has expired. Please log in.}

Here is how I pointed to your repo social_share: git: https://github.com/dpacchi/social_share_improvements

dpacchi commented 2 years ago

@dpacchi unfortunately looks like this package may be abandoned, which is a shame given how many people seem to use it from the ratings. I tried pointing to your branch(which seemed to work given the required App ID attribute), but I cannot compile/build on iOS or Android. Here is the error from XCode (note it works fine for the original package). Is your branch public? Or any idea where this may be coming from?

2022-11-21 08:40:49.152 xcodebuild[24455:252580] DVTPortal: Service '<DVTPortalViewDeveloperService: 0x7ff2032607d0; action='viewDeveloper'>' encountered an unexpected result code from the portal ('1100') 2022-11-21 08:40:49.152 xcodebuild[24455:252580] DVTPortal: Error: Error Domain=DVTPortalServiceErrorDomain Code=1100 "Your session has expired. Please log in." UserInfo={payload={ creationTimestamp = "2022-11-21T13:40:49Z"; httpCode = 200; protocolVersion = QH65B2; requestUrl = "https://developerservices2.apple.com/services/QH65B2/viewDeveloper.action"; responseId = "f936065d-b15f-4c1f-9151-0282c387d779"; resultCode = 1100; resultString = "Your session has expired. Please log in."; userLocale = "en_US"; userString = "Your session has expired. Please log in."; }, NSLocalizedDescription=Your session has expired. Please log in.}

Here is how I pointed to your repo social_share: git: https://github.com/dpacchi/social_share_improvements

It seems you have to log in again in xcode

DennisAshford commented 2 years ago

@dpacchi I am logged in, and it built fine with the older share package. Having similar issues with Android. Was curious if you had this issue pointing to your repo for the package?

Edit: It may be a versioning issue. My min flutter SDK is set to 2.7.0. Or is the repo pointing toward your personal XCode account anywhere?

ShekarMudaliyar commented 2 years ago

Apologies for the wait. I kept this project on hold as i was busy in some other work. I will be starting work on this from this week. Also i wanted to rewrite this package as its too old to be maintained. Please email me if anyone wants to give me a hand in this project.

Thank you everyone for the contribution really appreciate it.😄

DennisAshford commented 2 years ago

@ShekarMudaliyar 🙌 🙌

I am not skillful enough to contribute code, but I will be contributing some coffee to the effort 😃. Actually, just tried to donate and the PayPal link isn't working, FYI.

dpacchi commented 2 years ago

@ShekarMudaliyar nice to hear you! Rewriting this package from scratch could be a good idea, and that's what I have done with some of the features in my PR. Feel free to approve it, take parts of the code in it, or just take inspiration.

This are the main features I've edited / rewritten

I'd love to know what you decide to do with the rewriting of this package. Ciao!

DennisAshford commented 2 years ago

Just FYI, if anyone runs into the error I mentioned above, a simple Flutter Upgrade did the trick for me. The newest package requires a newer version of Flutter than I had.

arpitBhalla commented 1 year ago

Is there any update?

bhargav6744 commented 8 months ago

Any update on the same, i can help writing iOS Part if needed @ShekarMudaliyar